Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a redis instance to relay docker-compose #1869

Open
11 tasks
Tracked by #1625
georgi-l95 opened this issue Nov 1, 2023 · 2 comments · May be fixed by #3107
Open
11 tasks
Tracked by #1625

Add a redis instance to relay docker-compose #1869

georgi-l95 opened this issue Nov 1, 2023 · 2 comments · May be fixed by #3107
Assignees
Labels
good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. Internal For changes that affect the project's internal workings but not its outward-facing functionality.
Milestone

Comments

@georgi-l95
Copy link
Collaborator

georgi-l95 commented Nov 1, 2023

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to Hedera or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'Good First Issue' is to help you make your first contribution to Hedera.

👾 Description of the issue

The current docker-compose.yml starts the HTTP server container and the Web Socket server container, but does not include a redis container. If redis is not enabled, and used by each server the cache will not be shared.

Proposed Solution:

Add a redis container to the docker-compose.xml and ensure that the servers connect to it and use it as a shared cache.

Example Implementation


services:
  redis:
    image: redis:latest         # Uses the official Redis image from Docker Hub
    container_name: redis_server # Optional: Names the container 'redis_server'
    ports:
      - '6379:6379'             # Maps port 6379 of the host to port 6379 of the container
    volumes:
      - redis-data:/data        # Persists Redis data using a named volume
    restart: always             # Ensures the container restarts automatically if it stops

volumes:
  redis-data:                   # Declares a named volume for persistent storage

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.

  • Claim this issue: Comment below that you are interested in working on the issue
  • Wait for assignment: A community member with the given rights will add you as an assignee of the issue
  • Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
  • Solve the issue in your branch.
  • Commit your changes: Here, it is needed to add sign-off information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md
  • Start a Pull Request (PR): We have a pattern for naming pull requests that a GitHub Action checks. We use that pattern to support the creation of automatic release notes.
  • Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the Hedera developer community for support.
  • Wait for reviews: Members of the Hedera developer community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
  • You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of the Hedera community as an open-source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional Information

If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

@Nana-EC Nana-EC added the good first issue candidate Issues that can become a good first issue but need more description/context. label Sep 16, 2024
@ebadiere ebadiere added the hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. label Oct 11, 2024
@hendrikebbers hendrikebbers added good first issue Good for newcomers and removed good first issue candidate Issues that can become a good first issue but need more description/context. labels Oct 14, 2024
@sahil9001
Copy link

hey @hendrikebbers , can you please assign me this?

@sahil9001 sahil9001 linked a pull request Oct 16, 2024 that will close this issue
2 tasks
@sahil9001
Copy link

Raised a PR @hendrikebbers

@quiet-node quiet-node added the Internal For changes that affect the project's internal workings but not its outward-facing functionality. label Oct 22, 2024
@quiet-node quiet-node added this to the 0.59.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. Internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants