VM Image Controller, Webhook and Download/Upload Refactor for Various Backend Support #7170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Structure:
pkg/image/backend
pkg/image/common
pkg/image/backingimage
Problem:
VM Image should support various source backend
Solution:
Enhance VM Image implementation to have a clear interface for different image backend
Related Issue:
#6936
Test plan:
0cea310be669040bc682c75edd40fd6f81051bce
in my env)VirtualMachineImage
CRD$ kubectl apply -f deploy/charts/harvester-crd/templates/harvesterhci.io_virtualmachineimages.yaml
harvester
deployment with this PRharvester-webhook
deployment with this PR** Additional Context **
Since the VM image implementation has the new interfaces, the original unit testing is not applicable and removed. Creating a separate ticket to track the unit testing implementation #7204