-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #206] Added comments section for Blog #208
base: master
Are you sure you want to change the base?
Conversation
@harsh-9in Please review my pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Vrindagupta6828 This feature looks quite good by there is some changes
- Change the name field to the foreign key of the user so that it automatically add the logines in username
- for body use charfield of max length 500 instead of text field.
Then it it good to go.
@harsh-9in ok sure... |
@harsh-9in That would require user to be logged in to post a comment is that ok? |
@harsh-9in I tried to make the user a foreign key but it is showing many errors |
@harsh-9in I asked some doubt if you could please guide me. |
Sorry for the late reply I have seen this issue I Will tell you the sol soon. |
Did you see the solution? |
I am trying to solve it, wait till tonight, or I will merge it. |
Ohk thanks |
@harsh-9in Any update? Once you merge this pr only then can i work on the reply one |
reply one is not our priority even if it got merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz remove conflicts then it is good to go
@harsh-9in What are the conflicts i am unable to resolve it |
Related Issuse or bug
Added comments
Fixes: #206
Proposed Changes
I have made changes in many files namely models.py,views.py,forms.py etc.
Screenshots
Updated
:--------------------: |:--------------------:
**
**|