Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #206] Added comments section for Blog #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vrindagupta6828
Copy link
Contributor

Related Issuse or bug

Added comments

Fixes: #206

Proposed Changes

I have made changes in many files namely models.py,views.py,forms.py etc.

Screenshots

Updated
:--------------------: |:--------------------:
**
2
**|

@Vrindagupta6828
Copy link
Contributor Author

@harsh-9in Please review my pr.
And also please update my points regarding solving this issue and raising this issue.

Copy link
Owner

@harsh7in harsh7in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vrindagupta6828 This feature looks quite good by there is some changes

  • Change the name field to the foreign key of the user so that it automatically add the logines in username
  • for body use charfield of max length 500 instead of text field.

Then it it good to go.

@Vrindagupta6828
Copy link
Contributor Author

@harsh-9in ok sure...

@Vrindagupta6828
Copy link
Contributor Author

@harsh-9in That would require user to be logged in to post a comment is that ok?

@Vrindagupta6828
Copy link
Contributor Author

@harsh-9in I tried to make the user a foreign key but it is showing many errors

@Vrindagupta6828
Copy link
Contributor Author

@harsh-9in I asked some doubt if you could please guide me.

@harsh7in
Copy link
Owner

@harsh-9in I asked some doubt if you could please guide me.

Sorry for the late reply I have seen this issue I Will tell you the sol soon.

@Vrindagupta6828
Copy link
Contributor Author

@harsh-9in I asked some doubt if you could please guide me.

Sorry for the late reply I have seen this issue I Will tell you the sol soon.

Did you see the solution?

@harsh7in
Copy link
Owner

I am trying to solve it, wait till tonight, or I will merge it.

@Vrindagupta6828
Copy link
Contributor Author

Ohk thanks

@Vrindagupta6828
Copy link
Contributor Author

@harsh-9in Any update? Once you merge this pr only then can i work on the reply one

@harsh7in
Copy link
Owner

@harsh-9in Any update? Once you merge this pr only then can i work on the reply one

reply one is not our priority even if it got merge.

@harsh7in harsh7in self-requested a review December 30, 2020 06:27
Copy link
Owner

@harsh7in harsh7in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz remove conflicts then it is good to go

@Vrindagupta6828
Copy link
Contributor Author

@harsh-9in What are the conflicts i am unable to resolve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comments to each blog post
2 participants