feat: Adding support for response headers #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/plugin-react-query/src/templates/reactQueryCommon.liquid
Outdated
Show resolved
Hide resolved
cjlee01
reviewed
Oct 17, 2024
abhinavrastogi-harness
approved these changes
Oct 22, 2024
|
@vkbansal can we get a review on this please? |
cjlee01
approved these changes
Oct 22, 2024
|
This looks like a breaking change. Be careful while upgrading. Otherwise LGTM. |
|
Thanks for the review @vkbansal! |
|
Thanks for the review VKB!
Yes, we have a major version change, and we're doing a migration for all APIs using this client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for returning response headers as well from
queryandmutationhooks.This is required to obtain, for e.g., pagination related information for response headers.
Screenshots
NA
Contributor license agreement