Merge pull request #371 from kamilprzyb2/listbox-fix

Fix nTop not being assigned properly in ListBox:hitTest()
harbour · Jan 8, 2025 · 56bd635 · 56bd635
2 parents c2870ac + 2b6acca
commit 56bd635
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/ChangeLog.txt b/ChangeLog.txt
@@ -7,6 +7,10 @@
    Entries may not always be in chronological/commit order.
    See license at the end of file. */
 
+2025-01-08 13:14 UTC+0100 Kamil Przybylski (kprzybylski quay.pl)
+  * src/rtl/listbox.prg
+    ! fixed nTop variable not being assigned properly in ListBox:hitTest()
+
 2025-01-07 22:49 UTC+0100 Aleksander Czajczynski (hb fki.pl)
   * contrib/hbcurl/hbcurl.ch
     * updated HB_CURLOPT_SSL_OPTIONS: HB_CURLSSLOPT_*

diff --git a/src/rtl/listbox.prg b/src/rtl/listbox.prg
@@ -397,7 +397,7 @@ METHOD getText( nPos ) CLASS ListBox
 METHOD hitTest( nMRow, nMCol ) CLASS ListBox
 
    LOCAL nRet
-   LOCAL nTop
+   LOCAL nTop := ::nTop
    LOCAL nHit := 0
 
    /* Check hit on the scrollbar */
@@ -411,7 +411,6 @@ METHOD hitTest( nMRow, nMCol ) CLASS ListBox
    IF ! ::lIsOpen .OR. Empty( ::cHotBox + ::cColdBox )
       nRet := 0
    ELSE
-      nTop := ::nTop
       IF ::lDropDown
          nTop++
       ENDIF