Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ServerRoute's handler type to & HandlerDecorations #4466

Closed
wants to merge 1 commit into from

Conversation

hhanesand
Copy link

Seems like this type definition should use & and not | if the intent is to merge properties from HandlerDecorations into the lifecycle handler.

@kanongil kanongil added the types TypeScript type definitions label Nov 6, 2023
@Marsup Marsup self-assigned this Jan 29, 2024
@Marsup
Copy link
Contributor

Marsup commented Jan 29, 2024

I don't think it's the same thing, the handler can either be a method or an object matching a decoration (such as here), it can't be both.

@hhanesand hhanesand closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types TypeScript type definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants