Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node base64url option #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use node base64url option #43

wants to merge 1 commit into from

Conversation

geek
Copy link
Member

@geek geek commented Jul 30, 2023

Closes #37

kanongil
kanongil reviewed Jul 31, 2023
View reviewed changes
Copy link

@kanongil kanongil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can break for people who are still on pre node v14.18.0, which this release line is supposed?? to support.

Given that node will soon only support v18+ (v16 is EOL in little over a month), it will probably be better to just defer this PR till a breaking change that targets v18+.

@geek geek added the breaking changes Change that can breaking existing code label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanongil kanongil kanongil left review comments

@devinivy devinivy devinivy approved these changes

Assignees
No one assigned
Labels
breaking changes Change that can breaking existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use native 'base64url' buffer encoding
3 participants
@geek @kanongil @devinivy