Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faet: Add file prefix search function in s3link #153

Merged
merged 3 commits into from
Jun 16, 2024

Conversation

longjuan
Copy link
Member

在 S3关联 中支持文件名前缀搜索

fixes #142

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby May 25, 2024 13:51
@longjuan
Copy link
Member Author

目前文件名前缀支持/,当是一个feature可以关联子目录的文件吧

@JohnNiang
Copy link
Member

/ping @halo-dev/sig-halo

1 similar comment
@longjuan
Copy link
Member Author

/ping @halo-dev/sig-halo

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2024
Copy link

f2c-ci-robot bot commented Jun 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit bdd62cb into halo-dev:main Jun 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

建议关联S3文件增加搜索功能
2 participants