-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: new tags showing null post count on theme #7049
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7049 +/- ##
============================================
+ Coverage 56.99% 57.24% +0.24%
- Complexity 3999 4009 +10
============================================
Files 714 712 -2
Lines 24110 24148 +38
Branches 1585 1592 +7
============================================
+ Hits 13742 13823 +81
+ Misses 9756 9710 -46
- Partials 612 615 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
针对旧数据的建议:看能否在这里判断如果为 null 则设置成 0 呢。或者直接更改对应的数据类型为 int
。
.postCount(tag.getStatusOrDefault().getVisiblePostCount()) |
What type of PR is this?
/kind improvement
/area core
/milestone 2.20.x
What this PR does / why we need it:
修复新创建的标签在主题端展示关联文章数量为 null 的问题
仅对此 PR 之后新创建的标签有效,以前展示为 null 的标签需要手动更新一下
Which issue(s) this PR fixes:
Fixes #7042
Does this PR introduce a user-facing change?