-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for OpenHarmony in device OS detection #7045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Anyexyz , thanks for your contribution!
建议在对应的测试类中添加对应的测试用例:
halo/application/src/test/java/run/halo/app/security/device/DeviceServiceImplTest.java
Line 13 in 06f3c28
class DeviceServiceImplTest { |
已添加 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Hi @Anyexyz , Check Style 失败了,在合并前需要先解决一下 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for detecting OpenHarmony as a device operating system.
Which issue(s) this PR fixes:
Fixes #7039
Special notes for your reviewer:
This PR introduces minor changes in the device OS detection logic.
Does this PR introduce a user-facing change?