Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: add multi-role assignment support for users #7037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 15, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.20.x

What this PR does / why we need it:

支持为用户分配多个角色。

image

TODO:

  • Console / UC 侧边栏显示多个角色
  • 支持在管理端查看用户聚合的角色模板列表,或者在分配时显示所选角色其下的角色模板列表,能够让管理员清楚的知道用户具体权限。

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

WIP

Does this PR introduce a user-facing change?

Copy link

f2c-ci-robot bot commented Nov 15, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Nov 15, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Nov 15, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 15, 2024
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 15, 2024
Copy link

f2c-ci-robot bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ruibaby. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby changed the title feat: add multi-role assignment support for users WIP: feat: add multi-role assignment support for users Nov 15, 2024
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
Copy link

sonarcloud bot commented Nov 15, 2024

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (eff73dc) to head (87546da).
Report is 51 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7037      +/-   ##
============================================
+ Coverage     56.99%   57.23%   +0.23%     
- Complexity     3999     4007       +8     
============================================
  Files           714      712       -2     
  Lines         24110    24144      +34     
  Branches       1585     1590       +5     
============================================
+ Hits          13742    13819      +77     
+ Misses         9756     9710      -46     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues or PRs related to the Halo UI do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant