Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add grant permission and user deletion features to user detail page #6963

Merged
merged 4 commits into from
Oct 30, 2024
Merged

feat: add grant permission and user deletion features to user detail page #6963

merged 4 commits into from
Oct 30, 2024

Conversation

LEIYOUSU
Copy link
Contributor

@LEIYOUSU LEIYOUSU commented Oct 29, 2024 •
edited by ruibaby
Loading

What type of PR is this?

/area ui
/kind improvement
/milestone 2.20.x

What this PR does / why we need it:

期望支持在用户详情页面支持变更用户角色及删除用户 。

Which issue(s) this PR fixes:

Fixes #6944

Special notes for your reviewer:

Does this PR introduce a user-facing change?

支持在用户详情页面支持变更用户角色及删除用户 。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 29, 2024
ruibaby
ruibaby requested changes Oct 29, 2024
View reviewed changes
ui/src/locales/zh-CN.yaml Show resolved Hide resolved
@LEIYOUSU LEIYOUSU requested a review from ruibaby October 29, 2024 11:09
ruibaby
ruibaby requested changes Oct 30, 2024
View reviewed changes
ui/src/locales/en.yaml Outdated Show resolved Hide resolved
@LEIYOUSU LEIYOUSU requested a review from ruibaby October 30, 2024 03:18
@ruibaby ruibaby changed the title change-user-role-and-delete feat: add grant permission and user deletion features to user detail page Oct 30, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 30, 2024
ruibaby
ruibaby approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

感谢 @LEIYOUSU 的贡献。

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2024
@JohnNiang
Copy link
Member

在合并之前需要先解决一下 CI 错误。

@ruibaby
Copy link
Member

ruibaby commented Oct 30, 2024

在合并之前需要先解决一下 CI 错误。

Fixed

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.21%. Comparing base (eff73dc) to head (ea220d6).
Report is 44 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6963      +/-   ##
============================================
+ Coverage     56.99%   57.21%   +0.21%     
- Complexity     3999     4003       +4     
============================================
  Files           714      712       -2     
  Lines         24110    24123      +13     
  Branches       1585     1588       +3     
============================================
+ Hits          13742    13802      +60     
+ Misses         9756     9706      -50     
- Partials        612      615       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JohnNiang
JohnNiang approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 2c4e85f into halo-dev:main Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby approved these changes

@JohnNiang JohnNiang JohnNiang approved these changes

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@JohnNiang JohnNiang

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

期望支持在用户详情页面支持变更用户角色及删除用户
3 participants
@LEIYOUSU @JohnNiang @ruibaby