Exporter get variant information works on unions #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper function `get_variant_information` had an assertion about the ADT being anything but an union. This function works fine on unions, though. A union is just like a struct: the difference is the semantics of its only variant. This is unrelated to `VariantInformations`.
|
I don't expect this requires charon changes, the CI is only broken because I haven't yet fixed charon after last PR. That's just waiting on my CI: AeneasVerif/charon#418. |
|
That'll break charon here: https://github.com/AeneasVerif/charon/blob/75ebb6fccdf208b92343395cd05378790d0496c3/charon/src/bin/charon-driver/translate/translate_constants.rs#L87-L98 That's very easy to fix |
W95Psp
added a commit
to AeneasVerif/charon
that referenced
this pull request
Oct 14, 2024
W95Psp
added a commit
to AeneasVerif/charon
that referenced
this pull request
Oct 14, 2024
W95Psp
added a commit
to AeneasVerif/charon
that referenced
this pull request
Oct 14, 2024
|
This is green on Charon 😃 (https://github.com/AeneasVerif/charon/actions/runs/11329658628/job/31506938774) |
|
@Nadrieril I tagged you as a reviewer just in case you have opinions, but feel free to ignore 😃 |
Nadrieril
approved these changes
Oct 14, 2024
W95Psp
force-pushed
the
exporter-get_variant_information-works-on-unions
branch
from
0710210
to
8e81a9d
Compare
maximebuyse
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #997.
I have a meeting but then I'll push related changes in Charon.