Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macros): init #12

Merged
merged 2 commits into from
Nov 20, 2023
Merged

feat(macros): init #12

merged 2 commits into from
Nov 20, 2023

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Nov 14, 2023

No description provided.

Copy link
Contributor

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this down!

src/contributing/libraries_macros.md Outdated Show resolved Hide resolved
attribute that is never expanded.

In the engine, the OCaml module `Attr_payloads` offers an API to query
attributes easily. The types in crate `hax_lib_macros_types` and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give an example how to use the API in Attr_payloads?

Copy link
Collaborator Author

@W95Psp W95Psp Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'm gonna write something now tomorrow
(EDIT: got distracted by something else, will do that tomorrow)

Co-authored-by: jschneider-bensch <[email protected]>
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @jschneider-bensch is fine with this, let's get this in.

@W95Psp
Copy link
Collaborator Author

W95Psp commented Nov 20, 2023

Ok. That's better I think, I want to document that directly on the Attr_payloads module (this partially motivated cryspen/hax#361)

@jschneider-bensch
Copy link
Contributor

👍 That sounds good! Fine to merge, from my side.

@W95Psp W95Psp merged commit 65d553a into main Nov 20, 2023
1 check passed
@W95Psp W95Psp deleted the add-macros-explanations branch November 20, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants