Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add events editing portal and increase API ability #270

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Add events editing portal and increase API ability #270

wants to merge 41 commits into from

Conversation

CharlieCrisp
Copy link
Collaborator

@CharlieCrisp CharlieCrisp commented Jul 12, 2018 •
edited
Loading

This PR:

  • Changes the schema of events to include an id that is unique and used in the url. This is based on the assumption that we currently have no events in our database and can just blitz it rather than using migrations to change the schema.
  • Adds new API routes for editing and deleting events in our database. Admin credentials are required.
  • Adds a GUI for viewing all events, adding new events, editing and deleting existing events.

(Sorry for the monolithic PR)

Screenshots:

Events portal page:

image

Add new event page:

image

Edit Event Page:

image

Delete Event Page:

image

Individual Event View Page

image

@CharlieCrisp
Add helloworld page for displaying events in database
1bda1ef
@CharlieCrisp
Add basic functionality to iterate through events in database
7913e95
@CharlieCrisp
Display more information about individual events
09c3dad
@CharlieCrisp
Add credentials test to events portal
c5f039a
@CharlieCrisp
Remove eventDescription reference in docs
c90cc9f
@CharlieCrisp
Display event description in events portal
8513bba
@CharlieCrisp
Display all remaining fields in event portal
ce7ce41
@CharlieCrisp
Change event schema to include eventId
1388210
@CharlieCrisp
Add individual event view route
3ad3fe8
@CharlieCrisp
Use variable fields in events to allow future editing
623ce07
@CharlieCrisp
Rename add event handler
6b9fc95
@CharlieCrisp
Add empty event edit handler to api
3306e3d
@CharlieCrisp
Display event titles more clearly
26f4766
@CharlieCrisp
Use vars not lets to allow Location properties to change
f8eb9f1
@CharlieCrisp
Add new api route for updating events
e5e8271
@CharlieCrisp
Update documentation to include edit_event api
ddd9381
@CharlieCrisp
Check database for events with matching id before adding
c66149f
@CharlieCrisp
Check for location in edit event api better
19a480a
@CharlieCrisp
Add api for deleting events
15cd58e
@CharlieCrisp
Update documentation to include delete events api
e6158f4
@CharlieCrisp CharlieCrisp changed the title Add events editing portal Add events editing portal and increase API ability Jul 12, 2018
@CharlieCrisp CharlieCrisp self-assigned this Jul 13, 2018
jaredkhan
jaredkhan reviewed Sep 9, 2018
View reviewed changes
Sources/HaCWebsiteLib/Location.swift
let longitude : Double
let address : String?
let venue : String?
var latitude : Double
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see why these should be variables

@jaredkhan
Copy link
Contributor

eventApiControllerTests needs updating to reflect these changes.

(Sorry, I know feedback would have been more helpful before you had a full-time job!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredkhan jaredkhan jaredkhan left review comments

@moosichu moosichu Awaiting requested review from moosichu

@Pinpickle Pinpickle Awaiting requested review from Pinpickle

At least 1 approving review is required to merge this pull request.

Assignees

@CharlieCrisp CharlieCrisp

Labels
priority high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharlieCrisp @jaredkhan