feat(HACBS-2226): create a task to clone a repo and update files given fileUpdates for repo. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theflockers
changed the title
theflockers
changed the title
theflockers
force-pushed
the
hacbs_2230
branch
2 times, most recently
from
f6afcbf
to
18dd935
Compare
|
@theflockers the story only talks about creating a task, not a pipeline. So maybe the pipeline is not needed at this stage? Also, it says that the format should be clearly defined. I know that you basically took what I had in my story (and I took it from the google doc linked from the feature/epic). But it would be good if this gets documented somewhere for future reference. Not sure about the best place though. Maybe it should be here? https://redhat-appstudio.github.io/book/book/release-service.html Also, where are the bash functions used in the task defined? I'd like to take a look. |
|
@mmalina I agree that the ticket does not say it, although to test it I had to create the Pipeline as the InternalServices controller can create the InternalRequest to run it. That said, I would rather rewrite the ticket adding the Pipeline to it. Maybe @scoheb can tell us what he thinks. About the doc, agreed as well. Not sure about the best place. The functions will be in another PR. I will link it here once I push it. |
|
we'll eventually add the tasks to https://github.com/redhat-appstudio/release-service-bundles/tree/main/catalog/pipeline/push-to-external-registry |
theflockers
commented
Jul 11, 2023
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
theflockers
referenced
this pull request
in konflux-ci/release-service-utils
Jul 13, 2023
This PR adds the installation of the glab tool and functions to handle gitlab repos. Relates to hacbs-release/app-interface-deployments#30
theflockers
referenced
this pull request
in konflux-ci/release-service-utils
Jul 13, 2023
This PR adds the installation of the glab tool and functions to handle gitlab repos. Relates to hacbs-release/app-interface-deployments#30
theflockers
referenced
this pull request
in konflux-ci/release-service-utils
Jul 17, 2023
This PR adds the installation of the glab tool and functions to handle gitlab repos. Relates to hacbs-release/app-interface-deployments#30
theflockers
referenced
this pull request
in konflux-ci/release-service-utils
Jul 18, 2023
…epos This PR adds the installation of the glab tool and functions to handle gitlab repos. Relates to hacbs-release/app-interface-deployments#30
theflockers
referenced
this pull request
in konflux-ci/release-service-utils
Jul 18, 2023
Jira: https://issues.redhat.com/browse/HACBS-2226 - installs the glab tool - adds functions to manage git and gitlab repos - adds Red Hat IT Root CA Relates to hacbs-release/app-interface-deployments#30
mmalina
reviewed
Jul 25, 2023
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
theflockers
commented
Jul 27, 2023
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
mmalina
reviewed
Jul 27, 2023
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
internal-services/catalog/file-updates-process-file-updates-task.yaml
Outdated
Show resolved
Hide resolved
|
PTAL @mmalina |
mmalina
reviewed
Jul 28, 2023
mmalina
approved these changes
Jul 28, 2023
This commit creates a new pipeline and task to process updates in yaml files for a given repo, ref and paths (json array) - creates file-updates pipeline - creates task-process-file-updates task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(HACBS-2226): create a task to clone a repo and update files given fileUpdates for repo.