Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RELEASE-1283): file-updates updates #225

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

feat(RELEASE-1283): file-updates updates #225

wants to merge 2 commits into from

Conversation

scoheb
Copy link
Contributor

@scoheb scoheb commented Nov 11, 2024 •
edited
Loading

  • allow file-updates-secret to be configurable
  • change reference to RHTAP to Konflux

@scoheb
feat(RELEASE-1283): file-updates secret update
a7655c2 
- allow file-updates-secret to be configurable

Signed-off-by: Scott Hebert <[email protected]>
@scoheb
feat(RELEASE-1283): file-updates naming
c92978f 
- change reference to RHTAP to Konflux

Signed-off-by: Scott Hebert <[email protected]>
@scoheb scoheb requested a review from a team as a code owner November 11, 2024 04:00
@johnbieren
Copy link
Contributor

Why do we need the secret to be configurable?

@scoheb
Copy link
Contributor Author

scoheb commented Nov 11, 2024

Why do we need the secret to be configurable?

Right now, the task is generic in that it can update multiple repos. Each repo may require its own project access token so a single secret may not work.

In addition, we may want to support creating MR for stage or prod and therefore we might to specify that via the RPA.

johnbieren
johnbieren reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Can you bump the version things? And when the catalog PR is opened for this change (adding the params to the internal request) can you link it to this?

johnbieren
johnbieren approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the version strings weren't bumped in main and this is stable so doesn't make sense now since we would have a conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happybhati happybhati happybhati approved these changes

@johnbieren johnbieren johnbieren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scoheb @johnbieren @happybhati