Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] FExpr Trigonometric #3454

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+242 −201
Open

[ENH] FExpr Trigonometric #3454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc2c3df
baby steps
samukweku Apr 3, 2023
463c0d8
trigonometric fexpr
samukweku Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/api/math/arccos.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

.. xfunction:: datatable.math.arccos
:src: src/core/expr/funary/trigonometric.cc resolve_op_arccos
:src: src/core/expr/funary/trigonometric.cc pyfn_arccos
:cvar: doc_math_arccos
:signature: arccos(x)

Expand Down
2 changes: 1 addition & 1 deletion docs/api/math/arcsin.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

.. xfunction:: datatable.math.arcsin
:src: src/core/expr/funary/trigonometric.cc resolve_op_arcsin
:src: src/core/expr/funary/trigonometric.cc pyfn_arcsin
:cvar: doc_math_arcsin
:signature: arcsin(x)

Expand Down
2 changes: 1 addition & 1 deletion docs/api/math/arctan.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

.. xfunction:: datatable.math.arctan
:src: src/core/expr/funary/trigonometric.cc resolve_op_arctan
:src: src/core/expr/funary/trigonometric.cc pyfn_arctan
:cvar: doc_math_arctan
:signature: arctan(x)

Expand Down
2 changes: 1 addition & 1 deletion docs/api/math/cos.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

.. xfunction:: datatable.math.cos
:src: src/core/expr/funary/trigonometric.cc resolve_op_cos
:src: src/core/expr/funary/trigonometric.cc pyfn_cos
:cvar: doc_math_cos
:signature: cos(x)

Expand Down
2 changes: 1 addition & 1 deletion docs/api/math/deg2rad.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

.. xfunction:: datatable.math.deg2rad
:src: src/core/expr/funary/trigonometric.cc resolve_op_deg2rad
:src: src/core/expr/funary/trigonometric.cc pyfn_deg2rad
:cvar: doc_math_deg2rad
:signature: deg2rad(x)

Expand Down
2 changes: 1 addition & 1 deletion docs/api/math/rad2deg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

.. xfunction:: datatable.math.rad2deg
:src: src/core/expr/funary/trigonometric.cc resolve_op_rad2deg
:src: src/core/expr/funary/trigonometric.cc pyfn_rad2deg
:cvar: doc_math_rad2deg
:signature: rad2deg(x)

Expand Down
2 changes: 1 addition & 1 deletion docs/api/math/sin.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

.. xfunction:: datatable.math.sin
:src: src/core/expr/funary/trigonometric.cc resolve_op_sin
:src: src/core/expr/funary/trigonometric.cc pyfn_sin
:cvar: doc_math_sin
:signature: sin(x)

Expand Down
2 changes: 1 addition & 1 deletion docs/api/math/tan.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

.. xfunction:: datatable.math.tan
:src: src/core/expr/funary/trigonometric.cc resolve_op_tan
:src: src/core/expr/funary/trigonometric.cc pyfn_tan
:cvar: doc_math_tan
:signature: tan(x)

Expand Down
10 changes: 0 additions & 10 deletions src/core/expr/funary/pyfn.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,6 @@ void py::DatatableModule::init_funary()
ADD_FN(&dt::expr::funary_pyfn, dt::expr::ARGS); \
register_args(dt::expr::ARGS, dt::expr::OP)

// Trigonometric
FUNARY(args_sin, Op::SIN);
FUNARY(args_cos, Op::COS);
FUNARY(args_tan, Op::TAN);
FUNARY(args_arcsin, Op::ARCSIN);
FUNARY(args_arccos, Op::ARCCOS);
FUNARY(args_arctan, Op::ARCTAN);
FUNARY(args_deg2rad, Op::DEG2RAD);
FUNARY(args_rad2deg, Op::RAD2DEG);

// Hyperbolic
FUNARY(args_sinh, Op::SINH);
FUNARY(args_cosh, Op::COSH);
Expand Down
9 changes: 0 additions & 9 deletions src/core/expr/funary/pyfn.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,6 @@ namespace dt {
namespace expr {


// Trigonometric
extern py::PKArgs args_sin;
extern py::PKArgs args_cos;
extern py::PKArgs args_tan;
extern py::PKArgs args_arcsin;
extern py::PKArgs args_arccos;
extern py::PKArgs args_arctan;
extern py::PKArgs args_deg2rad;
extern py::PKArgs args_rad2deg;

// Hyperbolic
extern py::PKArgs args_sinh;
Expand Down
Loading