DefaultTags() returns non-semver tags as-is.

drone-plugins#237 (comment)
gypapp · May 15, 2020 · 7300eb8 · 7300eb8
1 parent 05c329a
commit 7300eb8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/tags.go b/tags.go
@@ -43,7 +43,7 @@ func DefaultTags(ref string) []string {
 	v := stripTagPrefix(ref)
 	version, err := semver.NewVersion(v)
 	if err != nil {
-		return []string{"latest"}
+		return []string{v}
 	}
 	if version.PreRelease != "" || version.Metadata != "" {
 		return []string{

diff --git a/tags_test.go b/tags_test.go
@@ -35,8 +35,11 @@ func TestDefaultTags(t *testing.T) {
 		{"refs/tags/v1.0.0", []string{"1", "1.0", "1.0.0"}},
 		{"refs/tags/v1.0.0-alpha.1", []string{"1.0.0-alpha.1"}},
 
+		// not semver tags as-is
+		{"refs/tags/x1.0.0", []string{"x1.0.0"}},
+		{"refs/tags/local_test", []string{"local_test"}},
+
 		// malformed or errors
-		{"refs/tags/x1.0.0", []string{"latest"}},
 		{"v1.0.0", []string{"latest"}},
 	}