bank combiner: Add ability to copy all subgroups within a specified group #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs #65 |
…r compressed waveforms in banks
GarethCabournDavies
force-pushed
the
combiner_copy_groups
branch
from
1428ae1 to
bc23c81
Compare
|
Tagging @spxiwh as I can't request reviewers |
1 task
spxiwh
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain circumstances - e.g. adding compressed waveforms to a bank, there are groups which should be directly copied into the combined bank without having to concatenate them in the same way as datasets.
This also fixes a bug where the datasets in the "combined" bank file do not have the same datatype as the un-combined banks, and adds some logging.