Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the html_use_smartypants option #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Respect the html_use_smartypants option #24

wants to merge 2 commits into from

Commits on Jan 31, 2017

  1. Respect the html_use_smartypants config option 

    Previously, this was ignored because the config option is implemented
by using a different HTMLTranslator in the case that the option is
True (which is the default). This PR switches from subclassing the
non-SmartyPants HTMLTranslator and instead uses calls to
`app.add_node` to override the visit/depart functions.

This removes the need to use `app.set_translator`, making our
Sphinx requirement more flexible. I tested building the demo with
the current version of Sphinx and earlier, and it worked all the
way to Sphinx 1.1, which failed for something unrelated to this change.
`setup.py` was updated accordingly.
    @tbekolay
    tbekolay committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    2806c95 View commit details
    Browse the repository at this point in the history

  2. Remove some unused imports 

    And fixed some indentation to follow PEP8 style.
    @tbekolay
    tbekolay committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    302bf83 View commit details
    Browse the repository at this point in the history