Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add service account authentication verification with gcloud(Issue #69) #71

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

doooosoooo
Copy link

  • Add verify_firebase_auth function for service account authentication check
  • Use gcloud auth to get access token before Firebase CLI execution
  • Implement retry mechanism with max 30s wait time
  • Prevent deployment failures caused by authentication timing issues

- Add verify_firebase_auth function for service account authentication check
- Use gcloud auth to get access token before Firebase CLI execution
- Implement retry mechanism with max 30s wait time
- Prevent deployment failures caused by authentication timing issues
@doooosoooo
Copy link
Author

Problem

When using service account authentication in the Firebase App Distribution step,
there can be timing issues where the deployment attempts to proceed before the
authentication process is fully completed, leading to deployment failures.

Solution

  • Added a verify_firebase_auth function that:
    • Explicitly authenticates with gcloud using the service account
    • Verifies the authentication status using firebase projects:list
    • Implements a retry mechanism (max 30s) to ensure authentication is complete
    • Fails early if authentication cannot be verified

Test Results

  • Tested with service account authentication
  • Successfully prevented timing-related deployment failures
  • Maintains backward compatibility with Firebase token authentication method

The changes only affect service account authentication flow and do not modify
the existing Firebase token authentication behavior.

@doooosoooo doooosoooo changed the title fix: Add service account authentication verification with gcloud fix: Add service account authentication verification with gcloud(Issue #69) Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant