Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ViewportSettings.Transparent #3886

Draft
wants to merge 7 commits into
base: v2_develop
Choose a base branch
from

Conversation

tig
Copy link
Collaborator

@tig tig commented Dec 14, 2024

Fixes

For

We need the concept of a view that is transparent. In addition I've found that View.Draw has some errors in it regarding in how clipping is done.

This PR fixes those issues and adds the new capability.

  • Adds ViewportSettings.Transparent enabling see-through/click-through views
  • Adds ViewportSettingsEditor to Scenarios and expands AllViewsTester to utilize

Proposed Changes/Todos

  • Add ViewportSettings.Transparent
  • Add ViewportSettingsEditor to Scenarios and expand AllViewsTester to utilize
  • Upgrade ViewportSettings scenario to use ViewportSettingsEditor and illustrate transparency
  • Add ViewportSettings.Transparent unit tests

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig
Copy link
Collaborator Author

tig commented Dec 14, 2024

TVWS3h6 1

Note, it's unlikely that this will support a transparent view with subviews that use transparent shadows.

@tig
Copy link
Collaborator Author

tig commented Dec 14, 2024

JypXlAc 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant