Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the build issue of F# example #3805

Open
wants to merge 1 commit into
base: v2_develop
Choose a base branch
from

Conversation

syohex
Copy link

@syohex syohex commented Oct 30, 2024

Fixes

F# example cannot be built with latest Termina.Gui. I got the following error when building.

% cd FSharpExample
% dotnet build
...
Build FAILED.

/home/syohei/tmp/Terminal.Gui/FSharpExample/Program.fs(22,18): error FS0039: The type 'Button' does not define the field, constructor or member 'Accept'. [/home/syohei/tmp/Terminal.Gui/FSharpExample/FSharpExample.fsproj]
    0 Warning(s)
    1 Error(s)

The property name was updated at 9990a55 however F# example has not been updated yet.

Proposed Changes/Todos

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@syohex syohex requested a review from tig as a code owner October 30, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants