Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3757. ShadowView throws System.IndexOutOfRangeException if left is less than zero. #3758

Closed

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Sep 25, 2024

Fixes

Proposed Changes/Todos

  • Prevents X being less than zero.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner September 25, 2024 16:17
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this and a few more in another PR.

@tig tig closed this Sep 25, 2024
@BDisp
Copy link
Collaborator Author

BDisp commented Oct 11, 2024

I've fixed this and a few more in another PR.

@tig this is still happening in the v2_develop branch. If you are going to releasing a new version, please don't forget to fix this. Thanks.

@tig
Copy link
Collaborator

tig commented Oct 11, 2024

I've fixed this and a few more in another PR.

@tig this is still happening in the v2_develop branch. If you are going to releasing a new version, please don't forget to fix this. Thanks.

It's fixed in #3691

@BDisp
Copy link
Collaborator Author

BDisp commented Oct 11, 2024

It's fixed in #3691

With the PR #3749. Right?

@BDisp
Copy link
Collaborator Author

BDisp commented Oct 11, 2024

With the PR #3749. Right?

I already confirmed that is really fixed.

@BDisp BDisp deleted the v2_3757_shadowview-horizontal-fix branch October 27, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShadowView throws System.IndexOutOfRangeException if left is less than zero.
2 participants