Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 2859 - Add more file dialog customization options #2863

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

tznind
Copy link
Collaborator

@tznind tznind commented Sep 21, 2023

Fixes #2859 - Add additional style customization options for FileDialog

I have also flipped the default order of the Ok/Cancel to match windows (Ok on left, Cancel on right). There is a style option to empower user to choose.

custom-button-text

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tznind tznind marked this pull request as ready for review September 21, 2023 05:52
@tznind tznind requested a review from tig as a code owner September 21, 2023 05:52
@Likarion
Copy link

One more suggestion.
Can you make the text of the "TextField tbPath" displayed so that the end part is visible in the case when the text does not fit in the field?
D:\Longlongpath\AnotherDir\OtherFolder\BlaBBla\UICatalog\MyFolder\
Now:
D:\Longlongpath\AnotherDir\OtherFolder\BlaBBla\..
New:
..therDir\OtherFolder\BlaBBla\UICatalog\MyFolder\

@tznind
Copy link
Collaborator Author

tznind commented Sep 25, 2023 via email

This ensures the right side of text is always visible
@tznind
Copy link
Collaborator Author

tznind commented Sep 25, 2023

Please try with 2928508 . Should now always show right hand end of text.

@tig tig merged commit 5e79335 into gui-cs:v2_develop Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants