Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DrawLine event to TreeView for advanced rendering manipulation #2765

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

tznind
Copy link
Collaborator

@tznind tznind commented Jul 23, 2023

Fixes #_____ - Added DrawLine event to TreeView for advanced rendering manipulation

shot-2023-07-23_17-13-54
TreeView with files visible that uses DrawLine event to render files in yellow

Design

I have reused the RuneCell class for the line but I could instead use List<Attribute> and List<Rune>. Both feel a little janky though. RuneCell works with ColorScheme not Attribute so its not ideal. Changing to lists introduces the possibility of them going out of sync (e.g. where user changes 1 list but not the other). Finally I could change to Tuple<Rune,Attribute>. Let me know what you think

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tznind tznind marked this pull request as ready for review July 23, 2023 16:47
@tig tig merged commit 4dbf2f4 into gui-cs:v2_develop Jul 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants