Skip to content

Commit

Permalink
Fixes #3098 & #3099 - Slider bugs (#3121)
Browse files Browse the repository at this point in the history
* Fixed bugs

* Fixed #3098

* Fixed a slew of issues

* Fixed a slew more of issues

* Code cleanup. Fixed unit test failure

* Code cleanup.

* Code cleanup.

* Code cleanup.
  • Loading branch information
tig authored Jan 5, 2024
1 parent 7af54f3 commit c6570a5
Show file tree
Hide file tree
Showing 6 changed files with 638 additions and 533 deletions.
24 changes: 23 additions & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,24 @@ csharp_style_var_elsewhere = true:none

# ReSharper properties
resharper_align_linq_query = true
resharper_align_multiline_binary_patterns = true
resharper_align_multiline_calls_chain = true
resharper_align_multiline_extends_list = true
resharper_align_multiline_parameter = true
resharper_blank_lines_around_region = 1
resharper_braces_redundant = true
resharper_csharp_alignment_tab_fill_style = optimal_fill
resharper_csharp_max_line_length = 200
resharper_csharp_stick_comment = false
resharper_csharp_wrap_parameters_style = chop_if_long
resharper_force_attribute_style = separate
resharper_indent_type_constraints = true
#resharper_int_align_binary_expressions = true
resharper_int_align_comments = true
resharper_int_align_invocations = true
resharper_int_align_nested_ternary = true
resharper_int_align_switch_expressions = true
resharper_int_align_switch_sections = true
resharper_local_function_body = expression_body
resharper_remove_blank_lines_near_braces_in_declarations = true
resharper_use_roslyn_logic_for_evident_types = true
Expand Down Expand Up @@ -82,7 +92,19 @@ csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
csharp_style_prefer_not_pattern = true:suggestion
csharp_style_prefer_extended_property_pattern = true:suggestion
csharp_style_var_for_built_in_types = false:silent
csharp_style_var_for_built_in_types = true:none
resharper_wrap_before_linq_expression = true
resharper_wrap_chained_binary_expressions = chop_if_long
resharper_wrap_chained_binary_patterns = chop_if_long
resharper_xmldoc_indent_size = 2
resharper_xmldoc_indent_style = space
resharper_xmldoc_indent_text = DoNotTouch
resharper_xmldoc_linebreaks_inside_tags_for_elements_longer_than = 120
resharper_xmldoc_max_blank_lines_between_tags = 1
resharper_xmldoc_max_line_length = 100
resharper_xmldoc_space_before_self_closing = false
resharper_xmldoc_tab_width = 2
resharper_xmldoc_use_indent_from_vs = true

[*.{cs,vb}]
dotnet_style_operator_placement_when_wrapping = beginning_of_line
Expand Down
4 changes: 2 additions & 2 deletions Terminal.Gui/View/ViewDrawing.cs
Original file line number Diff line number Diff line change
Expand Up @@ -291,12 +291,12 @@ public void DrawHotString (string text, bool focused, ColorScheme scheme)
/// <param name="row">the row to move to, in view-relative coordinates.</param>
public void Move (int col, int row)
{
if (Driver.Rows == 0) {
if (Driver == null || Driver?.Rows == 0) {
return;
}

BoundsToScreen (col, row, out int rCol, out int rRow, false);
Driver.Move (rCol, rRow);
Driver?.Move (rCol, rRow);
}

/// <summary>
Expand Down
Loading

0 comments on commit c6570a5

Please sign in to comment.