Remove ability to unset commissioned length

guardian · Nov 1, 2024 · 2060a3c · 2060a3c
1 parent 9745099
commit 2060a3c
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/public/components/content-list-drawer/content-list-drawer.js b/public/components/content-list-drawer/content-list-drawer.js
@@ -332,23 +332,20 @@ export function wfContentListDrawer($rootScope, config, $timeout, $window, conte
             };
 
             $scope.updateCommissionedLength = function (newValue) {
-              updateField("commissionedLength", newValue);
-              if (newValue === "") {
-                return wfComposerService.deleteField(
-                  $scope.contentItem.composerId,
-                  "commissionedLength"
-                );
-              } else if ($scope.contentItem.missingCommissionedLengthReason !== null) {
+              // Don't allow commissioned length to be set to an empty string
+              if(newValue === "") return;
+              if ($scope.contentItem.missingCommissionedLengthReason !== null && $scope.contentItem.missingCommissionedLengthReason !== undefined) {
+                  updateField("missingCommissionedLengthReason", null);
                   wfComposerService.deleteField(
                       $scope.contentItem.composerId,
                       "missingCommissionedLengthReason"
                   );
               }
-
-              return wfComposerService.updateField(
-                $scope.contentItem.composerId,
-                "commissionedLength",
-                newValue
+              updateField("commissionedLength", newValue);
+              wfComposerService.updateField(
+                  $scope.contentItem.composerId,
+                  "commissionedLength",
+                  newValue
               );
             };