Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lazy loading default on checkouts #6727

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

andrewHEguardian
Copy link
Contributor

What are you doing in this PR?

Make the lazy loading router the default router for our checkouts

Trello Card

Why are you doing this?

Checklist item two of the above card. The goal is to move other routes into this router, without bundling more code.

How to test

Playwright tests

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Size Change: -257 kB (-10.94%) 👏

Total Size: 2.09 MB

Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/lazyRouter.js 0 B -93.2 kB (removed) 🏆
./public/compiled-assets/javascripts/[countryGroupId]/router.js 93.2 kB -161 kB (-63.36%) 🏆
./public/compiled-assets/webpack/311.js 0 B -40.1 kB (removed) 🏆
./public/compiled-assets/webpack/426.js 0 B -36.6 kB (removed) 🏆
./public/compiled-assets/webpack/checkout.js 13.6 kB -677 B (-4.75%)
./public/compiled-assets/webpack/oneTimeCheckout.js 9.42 kB -588 B (-5.88%)
./public/compiled-assets/webpack/219.js 39.2 kB +39.2 kB (new file) 🆕
./public/compiled-assets/webpack/9.js 36.3 kB +36.3 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.4 kB -1 B (0%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB -2 B (0%)
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 223 kB -1 B (0%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 67.3 kB -3 B (0%)
./public/compiled-assets/javascripts/error404Page.js 67.3 kB -4 B (-0.01%)
./public/compiled-assets/javascripts/error500Page.js 67.2 kB -5 B (-0.01%)
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 163 kB -5 B (0%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.6 kB -3 B (0%)
./public/compiled-assets/javascripts/payPalErrorPage.js 65.9 kB -2 B (0%)
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.6 kB -2 B (0%)
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73 kB +1 B (0%)
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 118 kB -6 B (-0.01%)
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 226 kB -1 B (0%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 160 kB -5 B (0%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 88.2 kB -2 B (0%)
./public/compiled-assets/webpack/136.js 2.17 kB -1 B (-0.05%)
./public/compiled-assets/webpack/186.js 3.35 kB 0 B
./public/compiled-assets/webpack/187.js 20.1 kB -6 B (-0.03%)
./public/compiled-assets/webpack/3.js 19.2 kB 0 B
./public/compiled-assets/webpack/344.js 2 kB -1 B (-0.05%)
./public/compiled-assets/webpack/397.js 10.2 kB -2 B (-0.02%)
./public/compiled-assets/webpack/706.js 107 kB 0 B
./public/compiled-assets/webpack/719.js 13.5 kB 0 B
./public/compiled-assets/webpack/754.js 9.92 kB 0 B
./public/compiled-assets/webpack/847.js 26 kB 0 B
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 8.74 kB -308 B (-3.4%)
./public/compiled-assets/webpack/ThankYou.js 1.05 kB -32 B (-2.97%)

compressed-size-action

Copy link
Contributor

@GHaberis GHaberis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@andrewHEguardian andrewHEguardian merged commit 007eada into main Jan 27, 2025
19 checks passed
@andrewHEguardian andrewHEguardian deleted the ahe/make-lazy-loading-default branch January 27, 2025 08:55
@prout-bot
Copy link

Seen on PROD (merged by @andrewHEguardian 7 minutes and 50 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants