Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-7266] Create alert banner #137

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

shamoon-guardian
Copy link
Contributor

@shamoon-guardian shamoon-guardian commented Nov 20, 2024

Description

WHAT
Add Alert Banner to source repository and make sure all design requirements are met mentioned in figma

WHY
For Homepage Customisation we have to use a alert banner to be showing in home front page but that alert banner can be used in more then one places so this Alert Banner should be added to source repository first

Figma:

Testing notes/instructions:

Checklist

  • Changes have been checked by the developer
  • Changes have been checked by the reviewers
  • Ui tested
Recommended reviewiers
  • Design review for UI changes from @guardian/design-system
  • Code review from @guardian/android-developers or @guardian/ios-developers
  • Optional code/API review from @guardian/client-side-infra
Specific notes/instructions for the reviewer:

For pull requests introducing UI changes:

  • Sign-off by Design:
  • Dark Mode
  • Tablet
  • Accessibility (e.g. VoiceOver):
Screenshots or videos:
Mobile Tablet
Light alert_banner_light_mobile alert_banner_light_tablet
Dark alert_banner_dark_mobile alert_banner_dark_tablet

@shamoon-guardian shamoon-guardian requested a review from a team as a code owner November 20, 2024 15:53
@ab-gnm ab-gnm self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants