Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Non-AWS dependency updates #1411

Merged
merged 13 commits into from
Jan 17, 2025
Merged

chore(deps): Non-AWS dependency updates #1411

merged 13 commits into from
Jan 17, 2025

Conversation

gu-scala-steward-public-repos[bot]
Copy link
Contributor

About this PR

Updates:

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version numbers

The following files still refer to the old version numbers.
You might want to review and update them manually.

project/Dependencies.scala
project/plugins.sbt
.git-blame-ignore-revs
riff-raff/public/stylesheets/bootstrap-slate.min.css
⚙ Adjust future updates

Add these to your .scala-steward.conf file to ignore future updates of these dependencies:

updates.ignore = [
  { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" },
  { groupId = "com.adrianhurt", artifactId = "play-bootstrap" },
  { groupId = "com.fasterxml.jackson.core", artifactId = "jackson-annotations" },
  { groupId = "com.fasterxml.jackson.core", artifactId = "jackson-core" },
  { groupId = "com.fasterxml.jackson.core", artifactId = "jackson-databind" },
  { groupId = "com.fasterxml.jackson.dataformat", artifactId = "jackson-dataformat-cbor" },
  { groupId = "com.fasterxml.jackson.dataformat", artifactId = "jackson-dataformat-yaml" },
  { groupId = "com.fasterxml.jackson.datatype", artifactId = "jackson-datatype-jdk8" },
  { groupId = "com.fasterxml.jackson.datatype", artifactId = "jackson-datatype-jsr310" },
  { groupId = "com.fasterxml.jackson.module", artifactId = "jackson-module-parameter-names" },
  { groupId = "com.fasterxml.jackson.module", artifactId = "jackson-module-scala" },
  { groupId = "com.gu.play-googleauth", artifactId = "play-v30" },
  { groupId = "com.typesafe.sbt", artifactId = "sbt-less" },
  { groupId = "org.apache.pekko", artifactId = "pekko-testkit" },
  { groupId = "org.postgresql", artifactId = "postgresql" },
  { groupId = "org.quartz-scheduler", artifactId = "quartz" },
  { groupId = "org.scala-lang", artifactId = "scala-library" },
  { groupId = "org.scalameta", artifactId = "sbt-scalafmt" },
  { groupId = "org.scalameta", artifactId = "scalafmt-core" },
  { groupId = "org.scalikejdbc", artifactId = "scalikejdbc" },
  { groupId = "org.webjars", artifactId = "bootstrap" }
]

Or, add these to slow down future updates of these dependencies:

dependencyOverrides = [
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.adrianhurt", artifactId = "play-bootstrap" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.fasterxml.jackson.core", artifactId = "jackson-annotations" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.fasterxml.jackson.core", artifactId = "jackson-core" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.fasterxml.jackson.core", artifactId = "jackson-databind" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.fasterxml.jackson.dataformat", artifactId = "jackson-dataformat-cbor" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.fasterxml.jackson.dataformat", artifactId = "jackson-dataformat-yaml" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.fasterxml.jackson.datatype", artifactId = "jackson-datatype-jdk8" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.fasterxml.jackson.datatype", artifactId = "jackson-datatype-jsr310" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.fasterxml.jackson.module", artifactId = "jackson-module-parameter-names" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.fasterxml.jackson.module", artifactId = "jackson-module-scala" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.gu.play-googleauth", artifactId = "play-v30" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.typesafe.sbt", artifactId = "sbt-less" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.apache.pekko", artifactId = "pekko-testkit" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.postgresql", artifactId = "postgresql" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.quartz-scheduler", artifactId = "quartz" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scala-lang", artifactId = "scala-library" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scalameta", artifactId = "sbt-scalafmt" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scalikejdbc", artifactId = "scalikejdbc" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.webjars", artifactId = "bootstrap" }
  }
]
labels: dependencies

This reverts commit e9492be.

This fixes the unit tests which are currently failing with:

```log
[info] - should correctly generate keyring *** FAILED ***
[info]   java.lang.IllegalStateException: You are using version 1.1.3 of Apache Pekko, but it appears you (perhaps indirectly) also depend on older versions of related artifacts. You can solve this by adding an explicit dependency on version 1.1.3 of the [pekko-protobuf-v3, pekko-slf4j, pekko-serialization-jackson, pekko-stream, pekko-actor-typed] artifacts to your project. Here's a complete collection of detected artifacts: (1.0.3, [pekko-actor-typed, pekko-protobuf-v3, pekko-serialization-jackson, pekko-slf4j, pekko-stream]), (1.1.3, [pekko-actor, pekko-testkit]). See also: https://pekko.apache.org/docs/pekko/current/common/binary-compatibility-rules.html#mixed-versioning-is-not-allowed
[info]   at org.apache.pekko.util.ManifestInfo.checkSameVersion(ManifestInfo.scala:188)
[info]   at org.apache.pekko.util.ManifestInfo.checkSameVersion(ManifestInfo.scala:166)
[info]   at org.apache.pekko.actor.ActorSystemImpl.liftedTree2$1(ActorSystem.scala:1050)
[info]   at org.apache.pekko.actor.ActorSystemImpl._start$lzycompute(ActorSystem.scala:1039)
[info]   at org.apache.pekko.actor.ActorSystemImpl._start(ActorSystem.scala:1038)
[info]   at org.apache.pekko.actor.ActorSystemImpl.start(ActorSystem.scala:1062)
[info]   at org.apache.pekko.actor.ActorSystem$.apply(ActorSystem.scala:283)
[info]   at play.api.libs.concurrent.ActorSystemProvider$.start(Pekko.scala:244)
[info]   at play.api.libs.concurrent.ActorSystemProvider.get$lzycompute(Pekko.scala:133)
[info]   at play.api.libs.concurrent.ActorSystemProvider.get(Pekko.scala:133)
[info]   ...
```
This reverts commit 1dbf590.

This version is not compatible with Riff-Raff at the moment.
See also #1408.
@akash1810 akash1810 merged commit d9930be into main Jan 17, 2025
3 checks passed
@akash1810 akash1810 deleted the update/non_aws branch January 17, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant