Use anchor tags for feed #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryophyta
force-pushed
the
pf/anchor-tags-for-feed
branch
from
14ddcba to
0241b75
Compare
|
re-implements some of #81 |
sb-dev
reviewed
Jan 24, 2025
| @@ -273,6 +280,32 @@ export function SearchContextProvider({ children }: PropsWithChildren) { | |||
| dispatch({ type: 'TOGGLE_AUTO_UPDATE' }); | |||
| }; | |||
|
|
|||
| const Link = ({ | |||
There was a problem hiding this comment.
It might be worth moving the Link component to it's own file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The main change is to refactor the feed view so that it uses a list of links (
<a>tags) instead of a table:cmd+clickbehaviour etc.Additional changes:
<EuiBadge>to display supplier info, rather than including it at the end of the headline/slug.How to test
How can we measure success?
Have we considered potential risks?
Images
Before and after
Accessibility