Revert "fix: use SupporterPlusV2 Zuora catalogue plans"

[jamesgorrie]

Reverts #279

I completely forgot - this worked on PROD. Now it doesn't.

The FrontendId in Zuora for PROD is Yearly | Monthly. In CODE it's YearlyV2 | MonthlyV2.

My suggestion is that we revert this change, and change CODE Zuora source data to reflect PROD.

An alternative would be to change the FrontendId in PROD to the V2 version, but I am unsure of the downstream knockon effects.

[johnduffell]

sounds good on the revert - actually I was thinking at the time maybe it would make more sense to change the IDs, but I was worried it might break other things. Clearly it doesn't! I assume there is no duplicate in PROD, the old one has been changed to something else? Otherwise it might get non deterministic.

[jamesgorrie]

I assume there is no duplicate in PROD, the old one has been changed to something else?

Great shout - they are actually the same in PROD - so we are getting lucky I think. Let's have a chat about how to deprecate these properly. Assuming the desire is to remove the references all together.

[jamesgorrie]

I've swapped the older products to MonthyV1 and YearlyV1

[johnduffell]

sounds good, either that or blank them out would probably be as good.