Improved server side JSON validation #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
reviewed
Jan 13, 2017
| } | ||
|
|
||
| val updatedAtom = PublishAtomCommand(id).process() | ||
| Ok(Json.toJson(updatedAtom)) |
There was a problem hiding this comment.
as we've removed the try/catch what happens when PublishAtomCommand(id).process() throws? Do we get a 500 and a sensible message still?
There was a problem hiding this comment.
Oops sorry. I've put back the try/catch
| } | ||
| } | ||
|
|
||
| def getAuditTrailForAtomId(id: String) = APIHMACAuthAction { implicit req => | ||
| Ok(Json.toJson(auditDataStore.getAuditTrailForAtomId(id))) | ||
| } | ||
|
|
||
| private def parse[T](raw: UserRequest[AnyContent])(fn: T => Result)(implicit reads: Reads[T]): Result = try { |
akash1810
approved these changes
Jan 13, 2017
| @@ -2,23 +2,23 @@ package controllers | |||
|
|
|||
| import javax.inject.Inject | |||
|
|
|||
| import _root_.util.{AWSConfig, ExpiryPoller, YouTubeConfig, YouTubeVideoUpdateApi} | |||
There was a problem hiding this comment.
Yeah. I double checked it was like that before I changed things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored out JSON validation in
Api2into a single method, which returns aBadRequestresponse detailing the errors.For example, missing out fields in the
createUI no longer causes a 500 but returns a list of the missing fields:Also update the front-end to clear out saving/publishing/searching state when an error occurs. This stops the save button from spinning forever.
NB: the error still shows up in red at the top forever (#187)