Add id to AudioBlockElement to fix missing media-id for audio assets on DCR rendered podcast pages
#27686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Add
idtoAudioBlockElementto fix missing media-id for audio assets on DCR rendered podcast pagesWhat does this change?
Following the Frontend approach
frontend/applications/app/views/fragments/audioBody.scala.html
Line 127 in 2a8e447
Unfortunately the id is applied at quite a high level in the
DotcomRenderingDataModelcall stack as we needcontent.elementsavailable in order to pull out the id.Screenshots
After
Checklist