Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the weather #27659

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Remove the weather #27659

merged 1 commit into from
Jan 9, 2025
+0 −1,250

Conversation

domlander
Copy link
Contributor

@domlander domlander commented Dec 10, 2024 •
edited
Loading

What is the value of this and can you measure success?

We no longer display the weather widget on the homepage, so weather related code can be safely deleted

What does this change?

Removes weather-related code from the codebase.

Checklist

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

Deploy build 3543 of dotcom:frontend-all to CODE

All deployment options

From guardian/actions-riff-raff.

@domlander domlander mentioned this pull request Dec 10, 2024
Closed
@domlander domlander force-pushed the doml/downpour branch 2 times, most recently from 05c24f9 to 699a677 Compare January 7, 2025 11:39
@domlander domlander marked this pull request as ready for review January 7, 2025 12:03
@domlander domlander requested a review from a team as a code owner January 7, 2025 12:03
marjisound
marjisound approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@marjisound marjisound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

dev-build/conf/routes Show resolved Hide resolved
@domlander domlander merged commit 181163a into main Jan 9, 2025
6 checks passed
@domlander domlander deleted the doml/downpour branch January 9, 2025 09:43
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @domlander 11 minutes and 46 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @domlander 13 minutes and 54 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marjisound marjisound marjisound approved these changes

Assignees
No one assigned
Labels
Seen-on-ADMIN-PROD Seen-on-FRONTS-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domlander @prout-bot @marjisound