Hide the second tier of most popular (most commented/shared) #27650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georges-GNM
changed the title
Georges-GNM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
CSS in frontend scares me, but this looks to be the right place to add a display none to hide the most commented and most shared sections in the most popular component: they were removed from DCR earlier in the year, and it looks like we intended to do the same in frontend.
I opted for display none rather than removing chunks of code. Again, css in frontend scares me and is not something we do anymore anyway, so I wanted to find a fast and simple way that would feel the least impactful if it caused an issue. Better suggestions welcome though.
Screenshots
Checklist