Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove High Merchandising from Targeting section in admin commercial tools #27525

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

emma-imber
Copy link
Contributor

@emma-imber emma-imber commented Oct 9, 2024

What does this change?

Removes High merchandising targeting information from the targeting window in the frontend commercial menu. There was quite a bit of underlying logic that we've been able to delete as it was only being used by this targeting information page.

Screenshots

Before

Screenshot 2024-10-10 at 15 11 47

After

Screenshot 2024-10-10 at 15 11 57

@emma-imber emma-imber marked this pull request as ready for review October 10, 2024 15:27
@emma-imber emma-imber requested a review from a team as a code owner October 10, 2024 15:27
@ashishpuliyel
Copy link
Member

I can't pretend I've fully reviewed this. But what a great PR!

Copy link
Member

@arelra arelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ ✨ ✨

@emma-imber emma-imber merged commit 97c859d into main Oct 14, 2024
6 checks passed
@emma-imber emma-imber deleted the ei/remove-high-merch-from-tools branch October 14, 2024 13:17
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @emma-imber 13 minutes and 2 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @emma-imber 13 minutes and 7 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants