Override logServerError in facia to add the isFullFrontRequest field
#27470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dom Lander <[email protected]>
domlander
approved these changes
Sep 11, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (created by @ioannakok and merged by @domlander 12 minutes and 7 seconds ago)
|
|
Seen on FRONTS-PROD (created by @ioannakok and merged by @domlander 12 minutes and 17 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
We are running an experiment to test whether we can stop using the lite version of fronts. We want our server error logs to tell us whether the user was in this experiment, to see if there is a relationship between 500s and users in this experiment.
What does this change?
Overrides
logServerErrorin facia to add theisFullFrontRequestfield to the log message.Checklist