Cricket Players Unique Name #27464
Closed
Cricket Players Unique Name #27464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannakok
force-pushed
the
cricket-unique-name
branch
from
b5a1aac to
fed1bf9
Compare
We need to be able to distinguish between bowlers and catchers that have the same surname. This is a first step to be able to know their unique name. Co-authored-by: Roberto Tyley <[email protected]>
ioannakok
force-pushed
the
cricket-unique-name
branch
from
3c6d6f6 to
c2531e2
Compare
ioannakok
commented
Sep 24, 2024
| import org.scalatest.matchers.should.Matchers | ||
| import test.{ConfiguredTestSuite, WithMaterializer, WithTestApplicationContext, WithTestExecutionContext, WithTestWsClient} | ||
|
|
||
| @DoNotDiscover class CricketPaDeserialisationTest |
There was a problem hiding this comment.
This test is WIP so I added @DoNotDiscover to keep the build green. At the moment it's failing with error:
cricket.feed.CricketPaDeserialisationTest *** ABORTED ***
[info] java.lang.NullPointerException:
[info] at test.WithMaterializer.materializer(package.scala:121)
[info] at test.WithMaterializer.materializer$(package.scala:121)
[info] at cricket.feed.CricketPaDeserialisationTest.materializer$lzycompute(CricketPaDeserialisationTest.scala:11)
[info] at cricket.feed.CricketPaDeserialisationTest.materializer(CricketPaDeserialisationTest.scala:11)
[info] at test.WithTestWsClient.$anonfun$lazyWsClient$1(package.scala:127)
[info] at common.Lazy.get(Lazy.scala:16)
[info] at common.Lazy$.conversionLazy(Lazy.scala:7)
[info] at test.WithTestWsClient.wsClient(package.scala:128)
[info] at test.WithTestWsClient.wsClient$(package.scala:128)
[info] at cricket.feed.CricketPaDeserialisationTest.wsClient$lzycompute(CricketPaDeserialisationTest.scala:11)
We will probably want to change the test anyway and use test data instead of hitting the PA API.
Examples of xml sports test data in the codebase:
https://github.com/guardian/frontend/tree/main/admin/test/football/testdata
https://github.com/guardian/frontend/blob/main/sport/test/resources/rugby/feed/live-scores.xml
ioannakok
changed the title
ioannakok
force-pushed
the
cricket-unique-name
branch
from
c2531e2 to
19c1bbf
Compare
We would like to be able to use the full name of a bowler or a catcher if two players in the same team share the same surname. We also want to leave the description as it is if there is no need for subsitution, e.g. when dismissal type is "Run Out" Co-authored-by: Roberto Tyley <[email protected]>
ioannakok
force-pushed
the
cricket-unique-name
branch
from
19c1bbf to
c694556
Compare
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
|
This PR was closed because it has been stalled for 3 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27442
We need to be able to distinguish between bowlers and catchers that have the same surname. This is a first step to be able to know their unique name.
What is the value of this and can you measure success?
What does this change?
Screenshots
Checklist