Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade PM2 #8910

Merged
merged 4 commits into from
Sep 28, 2023
Merged

chore(deps): upgrade PM2 #8910

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd888c4
chore(deps): upgrade PM2
jamesgorrie Sep 26, 2023
31d2e4b
chore(deps): remove and add pm2
jamesgorrie Sep 26, 2023
c68fa1f
Merge branch 'main' of github.com:guardian/dotcom-rendering into updg…
jamesgorrie Sep 27, 2023
4ede82a
Merge branch 'main' of github.com:guardian/dotcom-rendering into updg…
jamesgorrie Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,5 @@
"npm-run-all": "^4.1.5",
"prettier": "^2.8.8",
"typescript": "5.1.3"
},
"resolutions": {
"**/pm2/@pm2/io/semver": "6.3.1"
}
}
7 changes: 6 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16185,7 +16185,12 @@ semver-truncate@^3.0.0:
resolved "https://registry.yarnpkg.com/semver/-/semver-5.7.2.tgz#48d55db737c3287cd4835e17fa13feace1c41ef8"
integrity sha512-cBznnQ9KjJqU67B52RMC65CMarK2600WFnbkcaiwWq3xy/5haFJlshgnpjovMVJ+Hff49d8GEn0b87C5pDQ10g==

[email protected], [email protected], semver@^6.0.0, semver@^6.1.1, semver@^6.1.2, semver@^6.3.0, semver@^6.3.1:
[email protected]:
version "6.3.0"
resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.0.tgz#ee0a64c8af5e8ceea67687b133761e1becbd1d3d"
integrity sha512-b39TBaTSfV6yBrapU89p5fKekE2m/NwnDocOVruQFS1/veMgdzuPcnOM34M6CwxW8jH/lxEa5rBoDeUwu5HHTw==

semver@^6.0.0, semver@^6.1.1, semver@^6.1.2, semver@^6.3.0, semver@^6.3.1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesgorrie I'm not sure I follow this change 🤔. It looks like the net effect would be to downgrade the version of semver to 6.3.0, which was originally upgraded away from in #8715?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @JamieB-gu yes @pm2/io@~5.0.0 is still using [email protected]. In which case we need to keep the resolution.

Copy link
Member

@arelra arelra Sep 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly [email protected]'s dependency @pm2/io@~5.0.0 has been updated to address the semver vulnerability and is now at @pm2/[email protected]:

keymetrics/pm2-io-apm@c5996e3

As pm2 accepts a patch this should mean we can specifically install/upgrade pm2/io@~5.0.2 to pick up this update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there has been a few issues where yarn was following semver so not updating it's lockfile as it was technically backwards compatible.

So basically the same thing you're talking about @arelra.

I removed pm2 and re-added it which seems to have given us a more expected lockfile, but annoyingly we do still have high vulnerabilities, which I think are related to licensing.

version "6.3.1"
resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.1.tgz#556d2ef8689146e46dcea4bfdd095f3434dffcb4"
integrity sha512-BR7VvDCVHO+q2xBEWskxS6DJE1qRnb7DxzUrogb71CWoSficBxYsiAGd+Kl0mmq/MprG9yArRkyrQxTO6XjMzA==
Expand Down
Loading