Check package.json health
#7100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
force-pushed
the
mxdvl/better-package-json
branch
from
38e33ef to
d8b2b62
Compare
|
Size Change: -3 B (0%) Total Size: 506 kB ℹ️ View Unchanged
|
mxdvl
force-pushed
the
mxdvl/better-package-json
branch
from
d8b2b62 to
93952ab
Compare
mxdvl
force-pushed
the
mxdvl/better-package-json
branch
from
abc159e to
c5d5597
Compare
|
@mxdvl it looks like the CI checks for this aren't passing at the moment and the branch hasn't been updated for a couple of weeks, so I'm going to add the p.s. this looks like a really interesting project, I'm looking forward to reviewing it! |
bryophyta
added
the
prnouncer-ignore
mxdvl
force-pushed
the
mxdvl/better-package-json
branch
from
1ea0c62 to
b37be6e
Compare
⚡️ Lighthouse report for the changes in this PRReport for Article
|
⚡️ Lighthouse report for the changes in this PRReport for Front
|
I’ve rebased and fixed all the other tests, but there are some remaining issues with the actual checking. I don’t have too much bandwith to fix this at the minute, so happy to close if there’s not much interest from the team. |
mxdvl
force-pushed
the
mxdvl/better-package-json
branch
from
b37be6e to
8354971
Compare
Thanks for the update! Fwiw it seems like a really worthwhile check so I'd be very happy for it to be included at some point! I don't want to put more work on your plate though; is it something that would be useful to pair on at some point? |
- missing peer dependencies are specified - use tilde range for type dependencies - enforce it with CI - added list of known issues - bump some dependencies: - dompurify to v2.4
mxdvl
force-pushed
the
mxdvl/better-package-json
branch
from
8354971 to
c74578e
Compare
|
There was a suggestion that this would be better suited in a place like CSNX, so closing in favour of getting this through instead: guardian/csnx#393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Why?
We have started to see the issues related to dependencies:
@types/*dependencies in Enforce tilde ranges for packages with type definitions #6971Screenshots
See full run: https://github.com/guardian/dotcom-rendering/actions/runs/4063074923/jobs/6994876002