Use gu_hide_support_messaging cookie as the only source of truth for support messaging #13037
+13
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
rupertbates
commented
Dec 19, 2024
| @@ -51,8 +51,6 @@ const validateResponse = ( | |||
| isObject(response) && | |||
| isBoolean(response.showSupportMessaging) && | |||
| isObject(response.contentAccess) && | |||
| isBoolean(response.contentAccess.paidMember) && | |||
| isBoolean(response.contentAccess.recurringContributor) && | |||
There was a problem hiding this comment.
These were just missed in #12983
rupertbates
commented
Dec 19, 2024
| @@ -176,30 +103,30 @@ describe('withinLocalNoBannerCachePeriod', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('hasSupporterCookie', () => { | |||
| describe('shouldHideSupportMessaging', () => { | |||
There was a problem hiding this comment.
shouldHideSupportMessging is exactly equivalent to hasSupporterCookie now the one-time stuff has been removed, so hasSupporterCookie is no longer needed.
|
Size Change: -1.22 kB (-0.13%) Total Size: 930 kB
ℹ️ View Unchanged
|
rupertbates
changed the title
github-actions
bot
removed
the
run_chromatic
andrewHEguardian
approved these changes
Dec 19, 2024
|
Now that guardian/support-frontend#6643 has been merged we need to wait 90 days before merging to ensure that all one-time contributors who are entitled to fewer support asks have the correct cookie set.
#6643 added the new cookie to the old checkout, this PR adds it to the new generic one time checkout. We can merge this on 9th April 2025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Stop using the one time contributor cookie which is set by support-frontend on the thank you page to work out whether a user should see support messaging or not. From now on we will only use the 'hide support messaging' cookie, and support-frontend will be updated to set this instead of the other.
I have also removed the 90 day age check which was carried out on the previous cookie and will just set the hide support messaging cookie to expire after 90 days when creating it.