Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky Chromatic tests #13017

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Skip flaky Chromatic tests #13017

merged 2 commits into from
Dec 24, 2024

Conversation

domlander
Copy link
Contributor

@domlander domlander commented Dec 16, 2024

Closes #13015

What does this change?

Skips five flaky Chromatic tests. These tests often record false positives in Chromatic runs.

Why?

These slow down the development workflow of many teams. However, there is a risk that we will miss unexpected changes because of this, so we should look to fix these as soon as possible.

@domlander domlander added the run_chromatic Runs chromatic when label is applied label Dec 16, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 16, 2024
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

Size Change: 0 B

Total Size: 942 kB

ℹ️ View Unchanged
Filename Size
dotcom-rendering/dist/1000.client.web.********************.js 999 B
dotcom-rendering/dist/1026.client.web.********************.js 784 B
dotcom-rendering/dist/1076.client.web.********************.js 3.41 kB
dotcom-rendering/dist/1090.client.web.********************.js 752 B
dotcom-rendering/dist/1262.client.web.********************.js 4.49 kB
dotcom-rendering/dist/1301.client.web.********************.js 4.06 kB
dotcom-rendering/dist/1391.client.web.********************.js 725 B
dotcom-rendering/dist/1401.client.web.********************.js 441 B
dotcom-rendering/dist/1424.client.web.********************.js 11.5 kB
dotcom-rendering/dist/1476.client.web.********************.js 784 B
dotcom-rendering/dist/1477.client.web.********************.js 3.52 kB
dotcom-rendering/dist/1667.client.web.********************.js 918 B
dotcom-rendering/dist/1714.client.web.********************.js 2.87 kB
dotcom-rendering/dist/1891.client.web.********************.js 3.83 kB
dotcom-rendering/dist/1908.client.web.********************.js 4.25 kB
dotcom-rendering/dist/1940.client.web.********************.js 507 B
dotcom-rendering/dist/2310.client.web.********************.js 880 B
dotcom-rendering/dist/2482.client.web.********************.js 44.8 kB
dotcom-rendering/dist/267.client.web.********************.js 917 B
dotcom-rendering/dist/280.client.web.********************.js 531 B
dotcom-rendering/dist/281.client.web.********************.js 642 B
dotcom-rendering/dist/3109.client.web.********************.js 803 B
dotcom-rendering/dist/3213.client.web.********************.js 5.42 kB
dotcom-rendering/dist/3270.client.web.********************.js 961 B
dotcom-rendering/dist/3304.client.web.********************.js 853 B
dotcom-rendering/dist/3366.client.web.********************.js 2.19 kB
dotcom-rendering/dist/342.client.web.********************.js 4.17 kB
dotcom-rendering/dist/3473.client.web.********************.js 3.74 kB
dotcom-rendering/dist/348.client.web.********************.js 6.21 kB
dotcom-rendering/dist/3769.client.web.********************.js 22.7 kB
dotcom-rendering/dist/3789.client.web.********************.js 3.42 kB
dotcom-rendering/dist/39.client.web.********************.js 3.06 kB
dotcom-rendering/dist/3937.client.web.********************.js 3.87 kB
dotcom-rendering/dist/4237.client.web.********************.js 3.22 kB
dotcom-rendering/dist/4282.client.web.********************.js 685 B
dotcom-rendering/dist/4501.client.web.********************.js 4.29 kB
dotcom-rendering/dist/4628.client.web.********************.js 654 B
dotcom-rendering/dist/4640.client.web.********************.js 3.57 kB
dotcom-rendering/dist/4684.client.web.********************.js 3.17 kB
dotcom-rendering/dist/4714.client.web.********************.js 6.15 kB
dotcom-rendering/dist/4941.client.web.********************.js 890 B
dotcom-rendering/dist/5095.client.web.********************.js 4.17 kB
dotcom-rendering/dist/5550.client.web.********************.js 11.2 kB
dotcom-rendering/dist/5658.client.web.********************.js 750 B
dotcom-rendering/dist/5721.client.web.********************.js 3.64 kB
dotcom-rendering/dist/5757.client.web.********************.js 931 B
dotcom-rendering/dist/5880.client.web.********************.js 828 B
dotcom-rendering/dist/5922.client.web.********************.js 8.08 kB
dotcom-rendering/dist/6021.client.web.********************.js 10.7 kB
dotcom-rendering/dist/6044.client.web.********************.js 726 B
dotcom-rendering/dist/6061.client.web.********************.js 3.77 kB
dotcom-rendering/dist/6071.client.web.********************.js 577 B
dotcom-rendering/dist/6080.client.web.********************.js 3.27 kB
dotcom-rendering/dist/6135.client.web.********************.js 779 B
dotcom-rendering/dist/6149.client.web.********************.js 12.7 kB
dotcom-rendering/dist/6150.client.web.********************.js 1 kB
dotcom-rendering/dist/6398.client.web.********************.js 2.92 kB
dotcom-rendering/dist/6505.client.web.********************.js 1 kB
dotcom-rendering/dist/6574.client.web.********************.js 3.54 kB
dotcom-rendering/dist/6598.client.web.********************.js 780 B
dotcom-rendering/dist/6627.client.web.********************.js 10.4 kB
dotcom-rendering/dist/6638.client.web.********************.js 907 B
dotcom-rendering/dist/678.client.web.********************.js 804 B
dotcom-rendering/dist/6876.client.web.********************.js 2.67 kB
dotcom-rendering/dist/6880.client.web.********************.js 5.78 kB
dotcom-rendering/dist/6903.client.web.********************.js 3.21 kB
dotcom-rendering/dist/6931.client.web.********************.js 2.56 kB
dotcom-rendering/dist/6940.client.web.********************.js 526 B
dotcom-rendering/dist/7026.client.web.********************.js 5.41 kB
dotcom-rendering/dist/7116.client.web.********************.js 23 kB
dotcom-rendering/dist/719.client.web.********************.js 3.48 kB
dotcom-rendering/dist/7350.client.web.********************.js 3.32 kB
dotcom-rendering/dist/7351.client.web.********************.js 2.44 kB
dotcom-rendering/dist/7460.client.web.********************.js 6.85 kB
dotcom-rendering/dist/7513.client.web.********************.js 157 B
dotcom-rendering/dist/7540.client.web.********************.js 2.69 kB
dotcom-rendering/dist/7546.client.web.********************.js 7.4 kB
dotcom-rendering/dist/7691.client.web.********************.js 853 B
dotcom-rendering/dist/7861.client.web.********************.js 617 B
dotcom-rendering/dist/8030.client.web.********************.js 3.38 kB
dotcom-rendering/dist/8067.client.web.********************.js 3.38 kB
dotcom-rendering/dist/83.client.web.********************.js 750 B
dotcom-rendering/dist/8504.client.web.********************.js 827 B
dotcom-rendering/dist/8536.client.web.********************.js 595 B
dotcom-rendering/dist/8568.client.web.********************.js 2.95 kB
dotcom-rendering/dist/8626.client.web.********************.js 890 B
dotcom-rendering/dist/8697.client.web.********************.js 956 B
dotcom-rendering/dist/8833.client.web.********************.js 829 B
dotcom-rendering/dist/8920.client.web.********************.js 3.41 kB
dotcom-rendering/dist/895.client.web.********************.js 5.14 kB
dotcom-rendering/dist/9184.client.web.********************.js 493 B
dotcom-rendering/dist/9242.client.web.********************.js 3.75 kB
dotcom-rendering/dist/9288.client.web.********************.js 2.51 kB
dotcom-rendering/dist/9493.client.web.********************.js 785 B
dotcom-rendering/dist/9557.client.web.********************.js 921 B
dotcom-rendering/dist/9558.client.web.********************.js 3.53 kB
dotcom-rendering/dist/9646.client.web.********************.js 6.32 kB
dotcom-rendering/dist/9665.client.web.********************.js 4.04 kB
dotcom-rendering/dist/9721.client.web.********************.js 717 B
dotcom-rendering/dist/9735.client.web.********************.js 4.46 kB
dotcom-rendering/dist/9766.client.web.********************.js 3.2 kB
dotcom-rendering/dist/9771.client.web.********************.js 3.69 kB
dotcom-rendering/dist/9835.client.web.********************.js 647 B
dotcom-rendering/dist/9899.client.web.********************.js 669 B
dotcom-rendering/dist/9995.client.web.********************.js 20.3 kB
dotcom-rendering/dist/Accessibility-importable.client.web.********************.js 6.35 kB
dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js 2.85 kB
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 4.86 kB
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 424 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 3.63 kB
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 2.7 kB
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 2.66 kB
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.55 kB
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 2.59 kB
dotcom-rendering/dist/AudioPlayerWrapper-importable.client.web.********************.js 6.32 kB
dotcom-rendering/dist/AuEoy2024Wrapper-importable.client.web.********************.js 5.52 kB
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 2.63 kB
dotcom-rendering/dist/Branding-importable.client.web.********************.js 2.86 kB
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 37.2 kB
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 1.96 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.74 kB
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 5.77 kB
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 2.66 kB
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 8.09 kB
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 5.16 kB
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 538 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 2.29 kB
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js 1.93 kB
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 2.44 kB
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js 1.74 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 2.81 kB
dotcom-rendering/dist/Dropdown-importable.client.web.********************.js 1.72 kB
dotcom-rendering/dist/EditionSwitcherBanner-importable.client.web.********************.js 3.51 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 3.94 kB
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.02 kB
dotcom-rendering/dist/ExpandableMarketingCardWrapper-importable.client.web.********************.js 6.43 kB
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 1.93 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 3.8 kB
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 618 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 2.52 kB
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 347 B
dotcom-rendering/dist/FooterReaderRevenueLinks-importable.client.web.********************.js 3.5 kB
dotcom-rendering/dist/frameworks.client.web.********************.js 20.9 kB
dotcom-rendering/dist/FrontSubNav-importable.client.web.********************.js 7.37 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 6.24 kB
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 11.4 kB
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 7.97 kB
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.56 kB
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 15.8 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 10.2 kB
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 783 B
dotcom-rendering/dist/index.client.web.********************.js 45.8 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 2.9 kB
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js 852 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 8.47 kB
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 3.76 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 5.69 kB
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 2.3 kB
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 7.21 kB
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 435 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 6.54 kB
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.54 kB
dotcom-rendering/dist/LiveblogNotifications-importable.client.web.********************.js 4.81 kB
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 4.72 kB
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 7.05 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.87 kB
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.69 kB
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 4.67 kB
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 6.86 kB
dotcom-rendering/dist/MostViewedRightWithAd-importable.client.web.********************.js 5.04 kB
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 6.79 kB
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 2.49 kB
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 543 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 802 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 750 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 543 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 470 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.74 kB
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 2.53 kB
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 6.01 kB
dotcom-rendering/dist/ScrollableFeature-importable.client.web.********************.js 4.58 kB
dotcom-rendering/dist/ScrollableHighlights-importable.client.web.********************.js 5.61 kB
dotcom-rendering/dist/ScrollableMedium-importable.client.web.********************.js 2.35 kB
dotcom-rendering/dist/ScrollableSmall-importable.client.web.********************.js 2.32 kB
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 6.51 kB
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.22 kB
dotcom-rendering/dist/sentry.client.web.********************.js 794 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.95 kB
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 485 B
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js 4.65 kB
dotcom-rendering/dist/shimport.client.web.********************.js 2.8 kB
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 732 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 3.27 kB
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 4.46 kB
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 5.55 kB
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 5.83 kB
dotcom-rendering/dist/SlideshowCarousel-importable.client.web.********************.js 4.36 kB
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 4.83 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.68 kB
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 6.17 kB
dotcom-rendering/dist/StickyLiveblogAskWrapper-importable.client.web.********************.js 8.13 kB
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 2.41 kB
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.48 kB
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 1.23 kB
dotcom-rendering/dist/Titlepiece-importable.client.web.********************.js 13.5 kB
dotcom-rendering/dist/TopBar-importable.client.web.********************.js 9.29 kB
dotcom-rendering/dist/TopBarSupport-importable.client.web.********************.js 2.5 kB
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.13 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 2.91 kB
dotcom-rendering/dist/UsEoy2024Wrapper-importable.client.web.********************.js 6.03 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.88 kB
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 2.78 kB
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 6.06 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 3.63 kB

compressed-size-action

@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 16, 2024
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Dec 16, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 16, 2024
@domlander domlander changed the title Testing chromatic: do not merge Skip flaky Chromatic tests Dec 23, 2024
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Dec 23, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 23, 2024
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Dec 23, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 23, 2024
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Dec 23, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 23, 2024
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Dec 23, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 23, 2024
@domlander domlander mentioned this pull request Dec 23, 2024
5 tasks
@domlander domlander marked this pull request as ready for review December 23, 2024 15:16
@domlander domlander requested a review from a team as a code owner December 23, 2024 15:16
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@domlander domlander merged commit 121ed9b into main Dec 24, 2024
33 checks passed
@domlander domlander deleted the doml/chromatic branch December 24, 2024 09:43
@prout-bot
Copy link

Seen on PROD (merged by @domlander 8 minutes and 50 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Chromatic false positives
3 participants