[Fairground 🎡] Avatar Sizing #12938
Open
[Fairground 🎡] Avatar Sizing #12938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeddow91
commented
Dec 3, 2024
|
Size Change: +607 B (+0.07%) Total Size: 891 kB
ℹ️ View Unchanged
|
abeddow91
force-pushed
the
ab/fairground-avatar-sizing
branch
from
3b67c41 to
56b379e
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
cemms1
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Looking great, though I would avoid use of the word "fairground" wherever possible in the code. Would much prefer "beta" to reference the new containers
Might be good to have a quick session to go over some of these changes as there's a fair bit of design logic going on here
dotcom-rendering/src/components/Card/components/AvatarContainer.tsx
Outdated
Show resolved
Hide resolved
dotcom-rendering/src/components/Card/components/AvatarContainer.tsx
Outdated
Show resolved
Hide resolved
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
abeddow91
force-pushed
the
ab/fairground-avatar-sizing
branch
from
7bbe77a to
18e3574
Compare
abeddow91
force-pushed
the
ab/fairground-avatar-sizing
branch
from
c7d86f0 to
8456285
Compare
abeddow91
commented
Jan 7, 2025
| { breakpoint: 320, width: 75 }, | ||
| { breakpoint: 740, width: 140 }, | ||
| ]); | ||
| const decideImageWidths = ( |
There was a problem hiding this comment.
Previously, we only requested 2 sizes of avatar. This function follow the pattern of card picture to account for a wider range of image widths based on the image size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds new size options for avatars that are included in a fairground container. The current sizing exists alongside this.
It also specifies that opinion cards in fairground containers that are horizontally aligned on desktop and bottom aligned on mobile should render on the right and bottom accordingly.
The fairground container cards with an avatar also remove the top margin.
Why?
This is part of the fairground opinion redesign.
Screenshots