Create A Lightbox Component
#12700
Merged
Create A Lightbox Component
#12700
+77
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combines the web and apps lightbox setup into a single component. This puts the logic in a single place, hopefully making it easier to find and understand. For apps, this also means the component is now referenced once at the `ArticlePage` level, rather than separately in each layout file. This reduces repetition and matches the way it's handled for web.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: 0 B Total Size: 927 kB ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
domlander
reviewed
Oct 29, 2024
| switch (renderingTarget) { | ||
| case 'Web': | ||
| if ( | ||
| switches.lightbox === undefined || |
There was a problem hiding this comment.
The lightbox switch has three possible values: undefined, true or false. The first condition handles undefined. If it evaluates to false then the type is narrowed to boolean, which the second condition handles.
Technically you could rely on JavaScript's coercion behaviour to combine this into a single condition, which would implicitly convert undefined to false, but I prefer to handle these checks separately as I think it's clearer.
|
Seen on PROD (merged by @JamieB-gu 8 minutes and 49 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the web and apps lightbox setup into a single component. This puts the logic in a single place, hopefully making it easier to find and understand.
For apps, this also means the component is now referenced once at the
ArticlePagelevel, rather than separately in each layout file. This reduces repetition and matches the way it's handled for web.