-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a waveform to the AudioPlayer
component
#12670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 24, 2024
Size Change: 0 B Total Size: 921 kB ℹ️ View Unchanged
|
sndrs
force-pushed
the
e2e/add-waveform-to-audio-player
branch
from
October 24, 2024 12:26
1d4d8ab
to
0ac73e6
Compare
An error occurred while trying to automatically change base from
e2e/add-audio-player
to
main
October 24, 2024 14:28
sndrs
force-pushed
the
e2e/add-waveform-to-audio-player
branch
from
October 24, 2024 14:41
0ac73e6
to
acb3d2b
Compare
ashishpuliyel
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alex, I love this!?
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a waveform to the audio player. There's no way of generating a true representation of the audio without re-fetching it (you can't get audio data from an
audio
player) which would make an accurate graphic effectively the same file size as the podcast.Instead, this creates a plausible (but fake) waveform based on the URL of podcast (@oliverabrahams's idea).
So no two podcasts get the same waveform, but the same podcast gets the same each time.
The peak values are also deterministically shuffled so that repetitive URL parts (the host etc) don't end up creating the same shape across URLs.
Why?
a sense of authenticity
Screenshots