-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrollable medium setup #12628
Merged
Merged
Scrollable medium setup #12628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georges-GNM
force-pushed
the
gl/setup-scrollable-medium
branch
from
October 22, 2024 14:53
e5b03ad
to
b27bf21
Compare
Size Change: 0 B Total Size: 914 kB ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 22, 2024
abeddow91
approved these changes
Oct 24, 2024
Seen on PROD (merged by @Georges-GNM 10 minutes and 59 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the basic scrollable medium component, stories, and uses it in
decideContainer
.There'll be some future styling work to ensure the carousel layout and card rendering match with the intended designs.
Why?
Part of this ticket in the fairground project
Screenshots