-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add one time param to banner cta url #12625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +13 B (0%) Total Size: 914 kB ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 22, 2024
sookburt
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
tomrf1
approved these changes
Oct 22, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 22, 2024
Seen on PROD (merged by @charleycampbell 14 minutes and 26 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds in the oneTime frequency param to the choice card cta (trello card)
Why?
Currently when a user selects one off as their frequency on the banner choice cards when they click the continue cta the tab selected on the landing page is monthly. To improve the user experience, we are now passing in one time as a param in the url meaning that when the user continues to the landing page the one-time tab is selected.
Screenshots
Before
and on Continue click
After
and on Continue click
In code (sorry for the jazzy colours on the ticker!)